util: make util binding internal #22675
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cjihrig
added
the
semver-major
nodejs-github-bot
added
the
lib / src
33 tasks
targos
approved these changes
Sep 3, 2018
lpinca
approved these changes
Sep 3, 2018
devsnek
approved these changes
Sep 3, 2018
jasnell
approved these changes
Sep 4, 2018
BridgeAR
approved these changes
Sep 5, 2018
BridgeAR
added
the
author ready
trivikr
approved these changes
Sep 5, 2018
Refs: nodejs#22160 PR-URL: nodejs#22675 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
PR-URL: nodejs#22675 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
cjihrig
force-pushed
the
util-binding
branch
from
aa51316 to
2bf4697
Compare
|
Green resumed CI: https://ci.nodejs.org/job/node-test-pull-request/17043/ |
addaleax
reviewed
Oct 14, 2018
| @@ -49,7 +49,8 @@ try { | |||
| } else { | |||
| // This throws for Node < 4.2.0 because there's no util binding and | |||
| // returns undefined for Node < 7.4.0. | |||
| Stream._isUint8Array = process.binding('util').isUint8Array; | |||
| const { internalBinding } = require('internal/bootstrap/loaders'); | |||
| Stream._isUint8Array = internalBinding('util').isUint8Array; | |||
There was a problem hiding this comment.
I think we want to revert this change, since it is only left in the file for compatibility with prior Node.js versions in readable-stream.
/cc @nodejs/streams
edit: #23662
addaleax
added a commit
to addaleax/node
that referenced
this pull request
Oct 14, 2018
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes